chore: use most recent gateway api conformance backend #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
==========================================
- Coverage 63.34% 63.33% -0.01%
==========================================
Files 123 123
Lines 19979 19979
==========================================
- Hits 12655 12654 -1
- Misses 6513 6514 +1
Partials 811 811 ☔ View full report in Codecov by Sentry. |
|
thanks @guydc, can we also use this image in quick start and other user guides :) |
|
/retest |
1 similar comment
|
/retest |
arkodg
previously approved these changes
Feb 27, 2024
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
force-pushed
the
chore-update-conformance-backend
branch
from
fd9ecc1 to
a46259d
Compare
|
sorry for force-push, I started from scratch after breaking something in the docs gen. |
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
/retest |
arkodg
approved these changes
Feb 28, 2024
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Feb 28, 2024
* use latest conformance in tests and docs Signed-off-by: Guy Daich <guy.daich@sap.com> * fix circuit breaker guide Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: zirain <zirain2009@gmail.com>
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Feb 28, 2024
* use latest conformance in tests and docs Signed-off-by: Guy Daich <guy.daich@sap.com> * fix circuit breaker guide Signed-off-by: Guy Daich <guy.daich@sap.com> --------- Signed-off-by: Guy Daich <guy.daich@sap.com> Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Gateway API changed their conformance tests to use a different echo server a while ago: kubernetes-sigs/gateway-api#2468. The new server is maintained by the Gateway API project (https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/echo-basic) and includes additional functionality like delayed response.
The enhanced feature set can be useful for testing scenarios like circuit breakers, connection limits, backend timeouts, etc.
Raising this PR to see if there are any e2e tests that fail due to change in server.