Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: wasm extension #2877
api: wasm extension #2877
Changes from all commits
071678b
076ed71
93747c9
98a36fb
dbaa9a0
8842ec9
a67eeea
ceadc72
2951f2c
def1839
fbb9200
63036a3
4c2d35a
4423952
79bba2f
2d86efc
dfe4218
d15ee16
9cf993f
039977c
219d598
74da998
b2d8796
dc10179
3131bb6
54b0eab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we autogenerate
name
,vm_id
androot_id
? and leave it out of the first iteration ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can generate the
name
, but the auto-generated name might not be as meaningful as the user-provided name.For
vm_id
androot_id
, we might want to expose them to the API to allows users to share VM or RootContext.In the first iteration, I think it's fine to leave them out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arkodg Envoy requires
name
to be unique within a VM. Since we have decided to leave vm_id out, EG will use a separate VM for each wasm extension, the name doesn't have to be unique in EnvoyExtensionPolicy. If we addvm_id
in the API in the future, then the name should be unique across all wasm extensions with the samevm_id
+wasm code combination.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.