Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated http filters for ExtAuth #2893

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

zhaohuabing
Copy link
Member

Remove duplicated http filters for Ext Auth.

Part of #2891

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner March 12, 2024 08:33
@zhaohuabing zhaohuabing marked this pull request as draft March 12, 2024 08:33
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.56%. Comparing base (975ef6e) to head (9f8ba6c).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/gatewayapi/securitypolicy.go 88.88% 0 Missing and 1 partial ⚠️
internal/xds/translator/basicauth.go 50.00% 0 Missing and 1 partial ⚠️
internal/xds/translator/extauth.go 90.00% 0 Missing and 1 partial ⚠️
internal/xds/translator/oidc.go 66.66% 0 Missing and 1 partial ⚠️
internal/xds/translator/utils.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
+ Coverage   64.52%   64.56%   +0.03%     
==========================================
  Files         122      122              
  Lines       21092    21106      +14     
==========================================
+ Hits        13610    13627      +17     
+ Misses       6634     6632       -2     
+ Partials      848      847       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing marked this pull request as ready for review March 12, 2024 09:34
@zhaohuabing zhaohuabing requested a review from guydc March 12, 2024 09:34
@zhaohuabing zhaohuabing force-pushed the remove-duplicated-filters branch from 70b29a2 to e3180ac Compare March 12, 2024 09:42
@zhaohuabing zhaohuabing marked this pull request as draft March 12, 2024 09:45
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review March 12, 2024 09:53
@zhaohuabing zhaohuabing force-pushed the remove-duplicated-filters branch from e3180ac to 8a8e841 Compare March 12, 2024 09:53
@zhaohuabing zhaohuabing changed the title Remove duplicated http filters Remove duplicated http filters for ExtAuth Mar 12, 2024
guydc
guydc previously approved these changes Mar 13, 2024
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 5679e41 into envoyproxy:main Mar 15, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants