api: increase rate-limit global rules limit #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ShyunnY <1147212064@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2906 +/- ##
==========================================
- Coverage 64.47% 64.45% -0.02%
==========================================
Files 122 122
Lines 21039 21039
==========================================
- Hits 13564 13561 -3
- Misses 6629 6630 +1
- Partials 846 848 +2 ☔ View full report in Codecov by Sentry. |
|
/retest |
shawnh2
approved these changes
Mar 13, 2024
|
can you add test for this? positive and negative. |
hi @ShyunnY, maybe add a test in |
ShyunnY
changed the title
Signed-off-by: ShyunnY <1147212064@qq.com>
|
Sorry, this was an oversight on my part. I have added |
arkodg
approved these changes
Mar 13, 2024
|
/retest |
zirain
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: increase rate-limit global rules limit
Which issue(s) this PR fixes:
Fixes #2900