odic doc #2921
Closed
odic doc #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
commented
Mar 14, 2024
| type: PathPrefix | ||
| value: / # Make sure this matches both /myapp1 and /myapp2 | ||
| backendRefs: | ||
| - name: non-existing-backend # This backend will never be used |
There was a problem hiding this comment.
EG uses 500 Internal Server Error direct response for an invalid backend. It would be better if we could response with 404 instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2921 +/- ##
=======================================
Coverage 64.52% 64.52%
=======================================
Files 122 122
Lines 21092 21092
=======================================
Hits 13610 13610
Misses 6634 6634
Partials 848 848 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Mar 14, 2024
| spec: | ||
| targetRef: | ||
| group: gateway.networking.k8s.io | ||
| kind: HTTPRoute |
There was a problem hiding this comment.
shoudnt this match the Gateway ? so it affects all the routes including the fallback route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2913