refactor: collapse eg-metrics-svc into eg-svc #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
reviewed
Mar 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
==========================================
- Coverage 64.62% 64.57% -0.05%
==========================================
Files 122 122
Lines 21115 21115
==========================================
- Hits 13645 13636 -9
- Misses 6624 6632 +8
- Partials 846 847 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ShyunnY <1147212064@qq.com>
ShyunnY
force-pushed
the
collapse-metrics-svc
branch
from
5b4367f to
f34dd03
Compare
Signed-off-by: ShyunnY <1147212064@qq.com>
|
/retest |
|
please kindly wait for #2935 |
|
@ShyunnY can you run |
|
@zirain Actually I can't run it, I need to change the existing |
Signed-off-by: ShyunnY <1147212064@qq.com>
|
/retest |
|
zirain
reviewed
Mar 16, 2024
Signed-off-by: ShyunnY <1147212064@qq.com>
zirain
approved these changes
Mar 16, 2024
arkodg
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor: Collapse envoy-gateway-metrics-service into envoy-gateway service with a metrics port
Which issue(s) this PR fixes:
Fixes #2919