Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support failOpen in ext auth #2948

Merged
merged 2 commits into from
Mar 18, 2024
Merged

feat: support failOpen in ext auth #2948

merged 2 commits into from
Mar 18, 2024

Conversation

deszhou
Copy link
Contributor

@deszhou deszhou commented Mar 17, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

  • support failOpen in ext auth, follow up PR

Fixes #2897

@deszhou
feat: support failOpen in ext auth
24bb02d 
Signed-off-by: Dennis Zhou <idennis.zhou@gmail.com>
@deszhou deszhou requested a review from a team as a code owner March 17, 2024 07:55
@codecov Codecov
Copy link

codecov bot commented Mar 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.58%. Comparing base (366e990) to head (0708c71).

Files Patch % Lines
internal/ir/zz_generated.deepcopy.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2948      +/-   ##
==========================================
- Coverage   64.59%   64.58%   -0.02%     
==========================================
  Files         122      122              
  Lines       21115    21123       +8     
==========================================
+ Hits        13640    13643       +3     
- Misses       6629     6634       +5     
  Partials      846      846

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deszhou
fix test
0708c71 
Signed-off-by: Dennis Zhou <idennis.zhou@gmail.com>
@deszhou
Copy link
Contributor Author

deszhou commented Mar 17, 2024

/retest

1 similar comment
@deszhou
Copy link
Contributor Author

deszhou commented Mar 17, 2024

/retest

zhaohuabing
zhaohuabing approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

arkodg
arkodg approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 2161064 into envoyproxy:main Mar 18, 2024
20 of 21 checks passed
ShyunnY pushed a commit to ShyunnY/gateway that referenced this pull request Apr 1, 2024
@deszhou @ShyunnY
feat: support failOpen in ext auth (envoyproxy#2948)
53756c1 
* feat: support failOpen in ext auth

Signed-off-by: Dennis Zhou <idennis.zhou@gmail.com>

* fix test

Signed-off-by: Dennis Zhou <idennis.zhou@gmail.com>

---------

Signed-off-by: Dennis Zhou <idennis.zhou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support failOpen in ext auth
3 participants
@deszhou @zhaohuabing @arkodg