Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xRoute and xPolicy support for egctl x status #2949

Merged
merged 7 commits into from
May 8, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Mar 17, 2024

What type of PR is this?

What this PR does / why we need it:

  • add support for xRoute and xPolicy input types
  • display Parents and Ancestors for xRoute or xPolicy
  • get rid of all the reflect errors handling, since we can promise all these fields exist

some usage example:

image
  • the kind name in ParentRef has been changed to lower case

Which issue(s) this PR fixes:

follow-up of #2631

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner March 17, 2024 12:45
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 67.21311% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 66.92%. Comparing base (4c52f10) to head (52f3ede).
Report is 4 commits behind head on main.

❗ Current head 52f3ede differs from pull request most recent head 9ca8774. Consider uploading reports for the commit 9ca8774 to get more accurate results

Files Patch % Lines
internal/cmd/egctl/status.go 67.21% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2949      +/-   ##
==========================================
+ Coverage   66.89%   66.92%   +0.03%     
==========================================
  Files         163      163              
  Lines       23453    23347     -106     
==========================================
- Hits        15689    15626      -63     
+ Misses       6838     6822      -16     
+ Partials      926      899      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Mar 20, 2024

/retest

arkodg
arkodg previously approved these changes May 8, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team May 8, 2024 01:59
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@arkodg arkodg merged commit 239fdd7 into envoyproxy:main May 8, 2024
23 checks passed
@shawnh2 shawnh2 deleted the egctl-status-policy branch May 8, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants