-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add xRoute and xPolicy support for egctl x status #2949
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2949 +/- ##
==========================================
+ Coverage 66.89% 66.92% +0.03%
==========================================
Files 163 163
Lines 23453 23347 -106
==========================================
- Hits 15689 15626 -63
+ Misses 6838 6822 -16
+ Partials 926 899 -27 ☔ View full report in Codecov by Sentry. |
/retest |
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
What type of PR is this?
What this PR does / why we need it:
xRoute
andxPolicy
input typesParents
andAncestors
forxRoute
orxPolicy
some usage example:
Which issue(s) this PR fixes:
follow-up of #2631