Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reuse xPolicy status methods for backendTLSPolicy #2950

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Mar 17, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

follow-up of #2631

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner March 17, 2024 13:08
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.63%. Comparing base (655ee5d) to head (3b6610b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
+ Coverage   64.60%   64.63%   +0.03%     
==========================================
  Files         122      121       -1     
  Lines       21147    21126      -21     
==========================================
- Hits        13661    13655       -6     
+ Misses       6638     6623      -15     
  Partials      848      848              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Mar 19, 2024

/retest

Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@shawnh2
Copy link
Contributor Author

shawnh2 commented Mar 20, 2024

/retest

@zhaohuabing zhaohuabing merged commit 0b122bd into envoyproxy:main Mar 20, 2024
15 of 19 checks passed
@shawnh2 shawnh2 deleted the backendtlspolicy-status branch March 21, 2024 00:48
ShyunnY pushed a commit to ShyunnY/gateway that referenced this pull request Apr 1, 2024
…xy#2950)

reuse xPolicy status func for backendTLSPolicy

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants