Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use unique ports in kubernetes service #2972

Closed
wants to merge 1 commit into from

Conversation

zetaab
Copy link
Contributor

@zetaab zetaab commented Mar 18, 2024

What type of PR is this?
fix: use unique ports in kubernetes service

What this PR does / why we need it:

It is not allowed to have duplicate port numbers in kubernetes service.

Which issue(s) this PR fixes:

Fixes #2964

Not sure is port-[port number] the correct way to fix this. But afaik that port name does not matter in any case because all calls are coming outside of kubernetes?

Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
@zetaab zetaab requested a review from a team as a code owner March 18, 2024 10:34
@zetaab zetaab closed this Mar 18, 2024
@zetaab zetaab deleted the fix/uniqueports branch March 18, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: duplicate port definition when using mergeGateway
1 participant