-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add trace for rate-limit #2974
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2974 +/- ##
==========================================
- Coverage 66.51% 58.20% -8.31%
==========================================
Files 161 165 +4
Lines 22673 27573 +4900
==========================================
+ Hits 15080 16050 +970
- Misses 6720 10572 +3852
- Partials 873 951 +78 ☔ View full report in Codecov by Sentry. |
de3225e
to
1e482a9
Compare
/retest |
This comment was marked as resolved.
This comment was marked as resolved.
site/content/en/latest/user/observability/rate-limit-observability.md
Outdated
Show resolved
Hide resolved
site/content/en/latest/user/observability/rate-limit-observability.md
Outdated
Show resolved
Hide resolved
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
/retest |
site/content/en/latest/tasks/observability/rate-limit-observability.md
Outdated
Show resolved
Hide resolved
PR is looking good @ShyunnY ! added some minor comments |
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
docs: update docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @ShyunnY ! thanks for addressing the feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be better add/update e2e test for this.
Thank you for your review, I will push e2e related updates in the near future |
What type of PR is this?
feat: add trace for rate-limit
Which issue(s) this PR fixes:
Fixes #2899