docs: set up linkinator for doc site #2980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
==========================================
+ Coverage 64.57% 64.59% +0.01%
==========================================
Files 122 122
Lines 21115 21147 +32
==========================================
+ Hits 13636 13660 +24
- Misses 6632 6639 +7
- Partials 847 848 +1 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Mar 19, 2024
arkodg
reviewed
Mar 19, 2024
|
thanks for fixing the dead links and automating the detection of it 🙈 |
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Xunzhuo
reviewed
Mar 20, 2024
|
|
||
| ## Prerequisites | ||
|
|
||
| Follow the steps from the [Quickstart](../../quickstart) guide to install Envoy Gateway and the example manifest. | ||
| Before proceeding, you should be able to query the example backend using HTTP. | ||
| Follow the steps from the [Quickstart](../quickstart) guide to install Envoy Gateway and the example manifest. Before proceeding, you should be able to query the example backend using HTTP. |
There was a problem hiding this comment.
this is not right I think, quickstart is outside of traffic dir
There was a problem hiding this comment.
this's right, you can double check it.
There was a problem hiding this comment.
Checking it manually is hard to maintain, do not wish to bring more broken links
There was a problem hiding this comment.
that's why istio/eg use linkinator, it will help at the most of cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #2979