-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for client cert #2984
API for client cert #2984
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
- Coverage 66.51% 64.49% -2.02%
==========================================
Files 161 121 -40
Lines 22673 21388 -1285
==========================================
- Hits 15080 13794 -1286
- Misses 6720 6723 +3
+ Partials 873 871 -2 ☔ View full report in Codecov by Sentry. |
4a306ad
to
2992133
Compare
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
2992133
to
b467aef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! As we also have an assignee for #2901 , it would be great to get this API in.
// TLS is the TLS configuration for the Envoy proxy to use when connecting to | ||
// backend services and external services, such as ExtAuth, ALS, OpenTelemetry, etc. | ||
// +optional | ||
TLS *EnvoyTLSConfig `json:"tls,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we call this ClientTLS ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guydc mentioned he wants to add some server-side settings later. If that's the case, then it would be better to use a more generalized name.
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Hi @zhaohuabing ! Did you see this #3218? It also covers the API/Impl for client cert based on previous discussion in the community meeting. |
Let's do it in #3218 since my focus is now on wasm and filter ordering. |
Related: #2536