Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for client cert #2984

Closed
wants to merge 17 commits into from
Closed

Conversation

zhaohuabing
Copy link
Member

Related: #2536

@zhaohuabing zhaohuabing requested a review from a team as a code owner March 20, 2024 06:20
@zhaohuabing zhaohuabing marked this pull request as draft March 20, 2024 06:20
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.49%. Comparing base (29946b0) to head (c54cc08).
Report is 68 commits behind head on main.

❗ Current head c54cc08 differs from pull request most recent head e4b4ac4. Consider uploading reports for the commit e4b4ac4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2984      +/-   ##
==========================================
- Coverage   66.51%   64.49%   -2.02%     
==========================================
  Files         161      121      -40     
  Lines       22673    21388    -1285     
==========================================
- Hits        15080    13794    -1286     
- Misses       6720     6723       +3     
+ Partials      873      871       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing marked this pull request as ready for review March 20, 2024 06:47
@zhaohuabing zhaohuabing requested review from guydc and arkodg March 20, 2024 06:49
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing self-assigned this Mar 21, 2024
guydc
guydc previously approved these changes Mar 27, 2024
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As we also have an assignee for #2901 , it would be great to get this API in.

// TLS is the TLS configuration for the Envoy proxy to use when connecting to
// backend services and external services, such as ExtAuth, ALS, OpenTelemetry, etc.
// +optional
TLS *EnvoyTLSConfig `json:"tls,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we call this ClientTLS ?

Copy link
Member Author

@zhaohuabing zhaohuabing Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guydc mentioned he wants to add some server-side settings later. If that's the case, then it would be better to use a more generalized name.

@zhaohuabing zhaohuabing requested review from arkodg and zirain March 28, 2024 00:21
Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@guydc
Copy link
Contributor

guydc commented Apr 19, 2024

Hi @zhaohuabing ! Did you see this #3218? It also covers the API/Impl for client cert based on previous discussion in the community meeting.

@zhaohuabing
Copy link
Member Author

Hi @zhaohuabing ! Did you see this #3218? It also covers the API/Impl for client cert based on previous discussion in the community meeting.

Let's do it in #3218 since my focus is now on wasm and filter ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants