-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gRPC Access Log Service (ALS) sink #3062
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3062 +/- ##
==========================================
+ Coverage 66.54% 66.56% +0.01%
==========================================
Files 157 157
Lines 21956 22175 +219
==========================================
+ Hits 14611 14761 +150
- Misses 6502 6563 +61
- Partials 843 851 +8 ☔ View full report in Codecov by Sentry. |
/retest |
/retest |
Signed-off-by: David Alger <davidmalger@gmail.com>
Signed-off-by: David Alger <davidmalger@gmail.com>
Signed-off-by: David Alger <davidmalger@gmail.com>
Signed-off-by: David Alger <davidmalger@gmail.com>
674a24a
to
04a216d
Compare
Signed-off-by: David Alger <davidmalger@gmail.com>
04a216d
to
31ace50
Compare
/retest |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
hey @davidalger still working on this one ? |
@davidalger are you still working on this? if not, I can take over this. |
@arkodg @zirain my apologies on the silent fading into the background on my part. I changed employers last month and have been unable to get back to it and pay the attention due my favorite OSS projects on Github. the plan was to wrap up #3190 first, although I see it looks like @zirain implemented much of that in another PR, so this could make it along rather nicely now. definitely feel free to pick it up and carry it across the finish line if you'd like to, as at least for the time being I have few spare cycles to spend doing so myself. |
hey np @davidalger, congratulations on the new gig :) |
closed in favor of #3626 |
What this PR does / why we need it:
This PR adds support for configuring a gRPC Access Log Service (ALS) logging sink implementing API added in #3078.