Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gRPC Access Log Service (ALS) sink #3062

Closed

Conversation

davidalger
Copy link
Contributor

@davidalger davidalger commented Mar 29, 2024

What this PR does / why we need it:

This PR adds support for configuring a gRPC Access Log Service (ALS) logging sink implementing API added in #3078.

@davidalger davidalger requested a review from a team as a code owner March 29, 2024 19:56
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 67.63485% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 66.56%. Comparing base (9416798) to head (31ace50).
Report is 279 commits behind head on main.

Files Patch % Lines
internal/provider/kubernetes/controller.go 31.91% 26 Missing and 6 partials ⚠️
internal/provider/kubernetes/indexers.go 28.00% 16 Missing and 2 partials ⚠️
internal/xds/translator/accesslog.go 78.57% 14 Missing and 1 partial ⚠️
internal/gatewayapi/listener.go 89.33% 6 Missing and 2 partials ⚠️
internal/provider/kubernetes/predicates.go 79.16% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3062      +/-   ##
==========================================
+ Coverage   66.54%   66.56%   +0.01%     
==========================================
  Files         157      157              
  Lines       21956    22175     +219     
==========================================
+ Hits        14611    14761     +150     
- Misses       6502     6563      +61     
- Partials      843      851       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidalger
Copy link
Contributor Author

/retest

@davidalger davidalger requested a review from zirain March 30, 2024 16:50
@davidalger
Copy link
Contributor Author

/retest

davidalger and others added 7 commits April 1, 2024 09:48
Signed-off-by: David Alger <davidmalger@gmail.com>
Signed-off-by: David Alger <davidmalger@gmail.com>
Signed-off-by: David Alger <davidmalger@gmail.com>
Signed-off-by: David Alger <davidmalger@gmail.com>
Signed-off-by: David Alger <davidmalger@gmail.com>
@davidalger davidalger marked this pull request as draft April 2, 2024 17:09
@davidalger davidalger changed the title feat: Support gRPC ALS sink configuration feat: gRPC Access Log Service (ALS) sink Apr 2, 2024
@davidalger davidalger force-pushed the algerdev/grpc-als-config branch 4 times, most recently from 674a24a to 04a216d Compare April 2, 2024 22:37
Signed-off-by: David Alger <davidmalger@gmail.com>
@davidalger davidalger force-pushed the algerdev/grpc-als-config branch from 04a216d to 31ace50 Compare April 2, 2024 22:46
@davidalger
Copy link
Contributor Author

/retest

Copy link

github-actions bot commented May 3, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added stale and removed stale labels May 3, 2024
Copy link

github-actions bot commented Jun 2, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 2, 2024
@arkodg
Copy link
Contributor

arkodg commented Jun 4, 2024

hey @davidalger still working on this one ?

@github-actions github-actions bot removed the stale label Jun 5, 2024
@zirain
Copy link
Contributor

zirain commented Jun 18, 2024

@davidalger are you still working on this? if not, I can take over this.

@davidalger
Copy link
Contributor Author

@arkodg @zirain my apologies on the silent fading into the background on my part. I changed employers last month and have been unable to get back to it and pay the attention due my favorite OSS projects on Github.

the plan was to wrap up #3190 first, although I see it looks like @zirain implemented much of that in another PR, so this could make it along rather nicely now. definitely feel free to pick it up and carry it across the finish line if you'd like to, as at least for the time being I have few spare cycles to spend doing so myself.

@arkodg
Copy link
Contributor

arkodg commented Jun 25, 2024

hey np @davidalger, congratulations on the new gig :)
looks like @zirain already took the PR forward, so should be okay to close this one, would be great if you can review #3626

@shawnh2
Copy link
Contributor

shawnh2 commented Jul 3, 2024

closed in favor of #3626

@shawnh2 shawnh2 closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants