Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil leader election #3096

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

zhaohuabing
Copy link
Member

fix: #3095

Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner April 5, 2024 08:15
@arkodg
Copy link
Contributor

arkodg commented Apr 5, 2024

/retest

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.49%. Comparing base (6941624) to head (07f4776).

Files Patch % Lines
api/v1alpha1/envoygateway_helpers.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3096   +/-   ##
=======================================
  Coverage   66.48%   66.49%           
=======================================
  Files         161      161           
  Lines       22647    22650    +3     
=======================================
+ Hits        15057    15061    +4     
+ Misses       6717     6716    -1     
  Partials      873      873           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team April 5, 2024 11:07
Copy link
Member

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arkodg arkodg merged commit dd034a0 into envoyproxy:main Apr 5, 2024
18 of 19 checks passed
@zhaohuabing zhaohuabing deleted the fix-nil-leaderelection branch April 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nil pointer when EnvoyGateway is provided but LeaderElection is not specified
4 participants