Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports custom metrics sink export period and timeout #3103

Merged
merged 7 commits into from
May 23, 2024

Conversation

ShyunnY
Copy link
Contributor

@ShyunnY ShyunnY commented Apr 6, 2024

What type of PR is this?

feat: supports custom metrics sink export period and timeout

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3038

Signed-off-by: ShyunnY <1147212064@qq.com>
@ShyunnY ShyunnY requested a review from a team as a code owner April 6, 2024 09:48
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 67.15%. Comparing base (e847d68) to head (7144db9).
Report is 29 commits behind head on main.

Files Patch % Lines
internal/metrics/register.go 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
- Coverage   67.41%   67.15%   -0.26%     
==========================================
  Files         166      166              
  Lines       19184    19463     +279     
==========================================
+ Hits        12932    13071     +139     
- Misses       5322     5447     +125     
- Partials      930      945      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 6, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added stale and removed stale labels May 6, 2024
@ShyunnY
Copy link
Contributor Author

ShyunnY commented May 14, 2024

cc: @arkodg
When will we start reviewing this feature? I hope to use this feature in the near future. :)

@arkodg
Copy link
Contributor

arkodg commented May 14, 2024

hey @ShyunnY are you running EG and hitting this issue around metric staleness ?

@ShyunnY
Copy link
Contributor Author

ShyunnY commented May 14, 2024

hey @ShyunnY are you running EG and hitting this issue around metric staleness ?

If you only use the default 60s export time, you will encounter staleness problems in some cases (which is what we don't want to see), so we hope to have controllable configuration.

ShyunnY added 3 commits May 14, 2024 10:59
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
@ShyunnY ShyunnY requested a review from arkodg May 20, 2024 10:52
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
@ShyunnY ShyunnY requested a review from arkodg May 22, 2024 14:50
@shawnh2
Copy link
Contributor

shawnh2 commented May 22, 2024

/retest

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: ShyunnY <1147212064@qq.com>
@shawnh2 shawnh2 requested a review from arkodg May 23, 2024 03:07
@shawnh2
Copy link
Contributor

shawnh2 commented May 23, 2024

/retest

@arkodg arkodg merged commit 2880a55 into envoyproxy:main May 23, 2024
24 of 26 checks passed
@guydc guydc mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: supports customized metrics flush period
3 participants