-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports custom metrics sink export period and timeout #3103
Conversation
Signed-off-by: ShyunnY <1147212064@qq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3103 +/- ##
==========================================
- Coverage 67.41% 67.15% -0.26%
==========================================
Files 166 166
Lines 19184 19463 +279
==========================================
+ Hits 12932 13071 +139
- Misses 5322 5447 +125
- Partials 930 945 +15 ☔ View full report in Codecov by Sentry. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
cc: @arkodg |
hey @ShyunnY are you running EG and hitting this issue around metric staleness ? |
If you only use the default 60s export time, you will encounter staleness problems in some cases (which is what we don't want to see), so we hope to have controllable configuration. |
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/retest |
What type of PR is this?
feat: supports custom metrics sink export period and timeout
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3038