-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add enable stats for peer endpoint of envoyproxy #3145
Conversation
Signed-off-by: ShyunnY <1147212064@qq.com>
Regarding the error in |
/retest |
please wait https://github.com/envoyproxy/gateway/pull/3146/files |
/retest |
hey @arkodg : I think we should start reviewing this PR as soon as possible, because this PR involves too much xds translator code, and the existing code is constantly changing... This will cause conflicts in this PR. |
Signed-off-by: ShyunnY <1147212064@qq.com>
hello, @arkodg It looks like this PR has been pending for a long time. Is there anything else I need to do now? I think I should listen to your opinion before trying to resolve the conflict, it could avoid more trouble |
hey @ShyunnY will review this one by tomorrow, sorry for the delay on this one |
it does not matter. |
PR looks good ! added a comment around the doc string |
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
/retest |
What type of PR is this?
feat: add enable stats for peer endpoint of envoyproxy
Which issue(s) this PR fixes:
Fixes #2824