Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enable stats for peer endpoint of envoyproxy #3145

Merged
merged 7 commits into from
Apr 21, 2024

Conversation

ShyunnY
Copy link
Contributor

@ShyunnY ShyunnY commented Apr 9, 2024

What type of PR is this?

feat: add enable stats for peer endpoint of envoyproxy

Which issue(s) this PR fixes:

Fixes #2824

Signed-off-by: ShyunnY <1147212064@qq.com>
@ShyunnY ShyunnY requested a review from a team as a code owner April 9, 2024 07:10
@ShyunnY ShyunnY marked this pull request as draft April 9, 2024 07:10
@ShyunnY
Copy link
Contributor Author

ShyunnY commented Apr 9, 2024

Regarding the error in docs-lint, is it caused by my modification? I looked at the error message and it appears that I didn't modify the link to the document. Is this a mistake?

@ShyunnY
Copy link
Contributor Author

ShyunnY commented Apr 9, 2024

/retest

@zirain
Copy link
Contributor

zirain commented Apr 9, 2024

Regarding the error in docs-lint, is it caused by my modification? I looked at the error message and it appears that I didn't modify the link to the document. Is this a mistake?

please wait https://github.com/envoyproxy/gateway/pull/3146/files

@ShyunnY ShyunnY marked this pull request as ready for review April 9, 2024 09:17
@ShyunnY
Copy link
Contributor Author

ShyunnY commented Apr 11, 2024

/retest

@ShyunnY
Copy link
Contributor Author

ShyunnY commented Apr 12, 2024

hey @arkodg :

I think we should start reviewing this PR as soon as possible, because this PR involves too much xds translator code, and the existing code is constantly changing... This will cause conflicts in this PR.

Signed-off-by: ShyunnY <1147212064@qq.com>
@shawnh2 shawnh2 requested review from zirain, arkodg and a team April 15, 2024 07:19
@ShyunnY
Copy link
Contributor Author

ShyunnY commented Apr 17, 2024

hello, @arkodg

It looks like this PR has been pending for a long time. Is there anything else I need to do now? I think I should listen to your opinion before trying to resolve the conflict, it could avoid more trouble

@arkodg
Copy link
Contributor

arkodg commented Apr 19, 2024

hey @ShyunnY will review this one by tomorrow, sorry for the delay on this one

@ShyunnY
Copy link
Contributor Author

ShyunnY commented Apr 19, 2024

hey @ShyunnY will review this one by tomorrow, sorry for the delay on this one

it does not matter.

@arkodg
Copy link
Contributor

arkodg commented Apr 19, 2024

PR looks good ! added a comment around the doc string

Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@zirain
Copy link
Contributor

zirain commented Apr 21, 2024

/retest

@zirain zirain merged commit e45dc38 into envoyproxy:main Apr 21, 2024
20 checks passed
@ShyunnY ShyunnY deleted the endpoint-stats branch April 21, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Endpoint Stats
3 participants