fix(chart): set ttlSecondsAfterFinished on certgen job to 30 by default

[JuniorJPDJ]

This is painless workaround for ArgoCD bug: argoproj/argo-cd#6880

[zhaohuabing]

@JuniorJPDJ Thanks for coming up with the workaround for using EG with ArgoCD. Is it because ArgoCD requires the job to exist for a while after it is finished?

[arkodg]

thanks for raising this ! I think 30s also works here.
weighing the pros and cons of setting this as a default - I believe the con of this is slower clean up (pressure on the k8s API server) ?

[JuniorJPDJ]

@zhaohuabing probably. It's not specified anywhere in the ArgoCD docs, but ArgoCD freezes forever on sync phase when job is deleted too quickly.

60s also allows to read logs without much timing pressure ;)

@arkodg you are probably right, but I'm not sure if it creates any pressure, and if it does, its so small and done only when upgrading/installing the chart, as it's just a hook

[arkodg]

@zhaohuabing probably. It's not specified anywhere in the ArgoCD docs, but ArgoCD freezes forever on sync phase when job is deleted too quickly.

60s also allows to read logs without much timing pressure ;)

@arkodg you are probably right, but I'm not sure if it creates any pressure, and if it does, its so small and done only when upgrading/installing the chart, as it's just a hook

cool, lets get this in, can we reduce this to 30 ? have you noticed cases where this is not enough, afaik 30s seems to work for users here

[JuniorJPDJ]

I've not seen any problems, but let me try in my setup again first.
Give me a few minutes :D

[JuniorJPDJ]

It worked without any problems - ready to merge. I already changed value, commit message and the PR name.

[arkodg]

@JuniorJPDJ can you run make generate and commit the changes

[JuniorJPDJ]

rebased and make generated

[arkodg]

LGTM thanks !

[zirain]

/retest