api: ext-proc processing mode #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Daich <guy.daich@sap.com>
guydc
force-pushed
the
api-extproc-procmode
branch
from
ae8c6b2 to
844558b
Compare
|
/retest |
|
/retest |
1 similar comment
|
/retest |
shawnh2
reviewed
Apr 11, 2024
|
@guydc sorry, linter works as expected now, can you fix it? |
1 similar comment
|
@guydc sorry, linter works as expected now, can you fix it? |
|
/retest |
|
/retest |
zhaohuabing
reviewed
Apr 18, 2024
api/v1alpha1/ext_proc_types.go
Outdated
| type ExtProcBodyProcessingMode string | ||
|
|
||
| const ( | ||
| StreamedExtProcBodyProcessingMode ExtProcBodyProcessingMode = "Streamed" |
There was a problem hiding this comment.
Could we add comments for each mode? This way they can show in the generated API docs.
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
Minor/non-blocking comment on naming:
|
yeah this API field is doing two things
can't think of a better name, so lets go ahead with the envoy specific name, since this feature is completely tied to envoy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows users to define how request and response header/body are processed by exteral processing service.
By default, nothing is sent to the external processor. If an empty request/response struct is defined, headers of request/response are sent. If the body attribute is configured, the body is processed according to the defined processing mode (Stream, Buffer, BufferPartial).
Which issue(s) this PR fixes:
xref: #3170