Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: move contribution out of version #3176

Merged
merged 6 commits into from
Apr 12, 2024
Merged

docs: move contribution out of version #3176

merged 6 commits into from
Apr 12, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 11, 2024

xref: #2987

zirain added 5 commits April 10, 2024 20:58
@zirain
move contirbutions out of versions
0d9149c 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
remove pre
b50d4a3 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
fix site links
a4f4b7a 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
fix README
fa588f5 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
Merge branch 'main' into docs-contribution
3c26227
@zirain zirain requested a review from a team as a code owner April 11, 2024 07:21
@zirain zirain changed the title Docs contribution docs: move contribution out of version Apr 11, 2024
wilsonwu
wilsonwu suggested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@wilsonwu wilsonwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it was my mistake for this translation, please help to remove this line.

site/content/zh/_index.md Outdated Show resolved Hide resolved
@wilsonwu wilsonwu mentioned this pull request Apr 11, 2024
Merged
@zirain
nit
4bc8ce6 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain force-pushed the docs-contribution branch from 510042f to 4bc8ce6 Compare April 12, 2024 01:52
@zirain
Copy link
Contributor Author

zirain commented Apr 12, 2024

/retest

Xunzhuo
Xunzhuo approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this, thanks for working on it : )

arkodg
arkodg approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !
feels good to delete lines, doesnt it ?

@arkodg arkodg merged commit cdab7d5 into envoyproxy:main Apr 12, 2024
20 checks passed
@zirain
Copy link
Contributor Author

zirain commented Apr 12, 2024

LGTM thanks ! feels good to delete lines, doesnt it ?

next is the releases folder, haha!

@zirain zirain deleted the docs-contribution branch April 12, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonwu wilsonwu wilsonwu requested changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zirain @wilsonwu @arkodg @Xunzhuo