Use native per-route config for basic auth #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
basic-auth-per-route
branch
4 times, most recently
from
5fab569 to
0a83056
Compare
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
basic-auth-per-route
branch
from
0d82082 to
71aab5f
Compare
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
guydc
reviewed
Apr 16, 2024
| basicAuthProto = &basicauthv3.BasicAuth{ | ||
| Users: &corev3.DataSource{ | ||
| Specifier: &corev3.DataSource_InlineBytes{ | ||
| InlineBytes: basicAuth.Users, |
There was a problem hiding this comment.
Are we using the first route's security policy basic config to define the top-level HCM "global" config? It's overriden on each route, but makes XDS look a bit strange... Maybe just leave it blank?
There was a problem hiding this comment.
Yeah, I'd like to leave it blank as well, but the Users field is mandatory.
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
guydc
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to native per-route config for basic auth to shrink HCM filter chain size.
Per-route config for basic auth has been supported in Envoy.