refactor: group xds backend traffic features for BackendTrafficPolicy #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
|
/retest |
arkodg
reviewed
Apr 15, 2024
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
arkodg
reviewed
May 10, 2024
| @@ -592,6 +592,7 @@ xdsIR: | |||
| distinct: false | |||
| name: "" | |||
| prefix: / | |||
| traffic: {} | |||
|
@shawnh2 resolve the conflicts, then we're good to go :-) |
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
…to xds-btp-group
Done |
shawnh2
commented
May 11, 2024
| ConfigType: &routev3.RetryPolicy_RetryHostPredicate_TypedConfig{ | ||
| TypedConfig: protocov.ToAny(&previoushost.PreviousHostsPredicate{}), | ||
| }, | ||
| rr := route.Traffic.Retry |
There was a problem hiding this comment.
skip the nil check here, since it's been checked outside this func
|
/retest |
arkodg
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2954, separated from #2926