-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support caCerts in secrets #3211
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
hey @ShyunnY can you rebase ? |
OK, I'll handle the conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you resolve the conflicts, then we are good to go! TIA!
Signed-off-by: ShyunnY <1147212064@qq.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3211 +/- ##
==========================================
- Coverage 67.15% 67.08% -0.08%
==========================================
Files 166 166
Lines 19463 19487 +24
==========================================
+ Hits 13071 13073 +2
- Misses 5447 5467 +20
- Partials 945 947 +2 ☔ View full report in Codecov by Sentry. |
/retest |
Conflict resolved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
What type of PR is this?
feat: support caCerts in secrets
Which issue(s) this PR fixes:
Fixes #2777