Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support caCerts in secrets #3211

Merged
merged 2 commits into from
May 23, 2024
Merged

feat: support caCerts in secrets #3211

merged 2 commits into from
May 23, 2024

Conversation

ShyunnY
Copy link
Contributor

@ShyunnY ShyunnY commented Apr 17, 2024

What type of PR is this?

feat: support caCerts in secrets

Which issue(s) this PR fixes:

Fixes #2777

@ShyunnY ShyunnY requested a review from a team as a code owner April 17, 2024 08:49
@ShyunnY ShyunnY marked this pull request as draft April 17, 2024 08:49
@ShyunnY ShyunnY marked this pull request as ready for review April 18, 2024 03:08
@ShyunnY
Copy link
Contributor Author

ShyunnY commented Apr 18, 2024

/retest

arkodg
arkodg previously approved these changes May 15, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team May 15, 2024 02:06
@arkodg
Copy link
Contributor

arkodg commented May 15, 2024

hey @ShyunnY can you rebase ?

@ShyunnY
Copy link
Contributor Author

ShyunnY commented May 15, 2024

hey @ShyunnY can you rebase ?

OK, I'll handle the conflict

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you resolve the conflicts, then we are good to go! TIA!

Signed-off-by: ShyunnY <1147212064@qq.com>
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 39.58333% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 67.08%. Comparing base (2880a55) to head (9fd9a08).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/provider/kubernetes/controller.go 8.00% 23 Missing ⚠️
internal/gatewayapi/backendtlspolicy.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3211      +/-   ##
==========================================
- Coverage   67.15%   67.08%   -0.08%     
==========================================
  Files         166      166              
  Lines       19463    19487      +24     
==========================================
+ Hits        13071    13073       +2     
- Misses       5447     5467      +20     
- Partials      945      947       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShyunnY
Copy link
Contributor Author

ShyunnY commented May 23, 2024

/retest

Signed-off-by: ShyunnY <1147212064@qq.com>
@ShyunnY ShyunnY requested a review from arkodg May 23, 2024 13:14
@ShyunnY
Copy link
Contributor Author

ShyunnY commented May 23, 2024

Conflict resolved!

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit a66cf2b into envoyproxy:main May 23, 2024
22 of 25 checks passed
@ShyunnY ShyunnY deleted the secret-ca branch May 24, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BackendTLSPolicy: Support CACerts in Secrets
3 participants