fix: match serviceName in tracing with mergedGateways topology #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnvergence
force-pushed
the
merge-svc-trace
branch
from
ec27985 to
70be6a5
Compare
|
/retest |
zirain
reviewed
Apr 17, 2024
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
merge-svc-trace
branch
from
7082daa to
34c471f
Compare
|
/retest |
|
just thinking if we should use |
arkodg
approved these changes
Apr 18, 2024
zirain
approved these changes
Apr 19, 2024
|
it would be better to see a xds translator test, but LGTM now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
When mergeGateways is enabled, tracing should set its service name to GatewayClass name, as there will be only one service for every gateway listener.
Which issue(s) this PR fixes:
Fixes #3210