Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use golang 1.N.P version syntax #3215

Merged
merged 2 commits into from
Apr 18, 2024
Merged

chore: use golang 1.N.P version syntax #3215

merged 2 commits into from
Apr 18, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Apr 17, 2024

What this PR does / why we need it:
CodeQL is reporting an invalid golang toolchain version syntax:

As of Go 1.21, toolchain versions must use the 1.N.P syntax.
1.22 in tools/src/setup-envtest/go.mod does not match this syntax and there is no additional toolchain directive, which may cause some go commands to fail.
CodeQL also found 9 other warnings like this. See the workflow log for details.

@guydc
use golang 1.N.P version syntax
67219e9 
Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc requested a review from a team as a code owner April 17, 2024 21:59
@guydc
Copy link
Contributor Author

guydc commented Apr 17, 2024

/retest

1 similar comment
@guydc
Copy link
Contributor Author

guydc commented Apr 17, 2024

/retest

shawnh2
shawnh2 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this, maybe that is the reason why I always receive toolchains not found for go1.22 error on my local dev env.

@zirain zirain merged commit 64b115f into envoyproxy:main Apr 18, 2024
17 checks passed
@yuluo-yx yuluo-yx mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnh2 shawnh2 shawnh2 approved these changes

@zirain zirain zirain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guydc @zirain @shawnh2