Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix commands for testing jwt based routing #3243

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

biefy
Copy link
Contributor

@biefy biefy commented Apr 22, 2024

Fix commands for testing jwt based routing.

What type of PR is this?
docs: Fix commands for testing jwt based routing

What this PR does / why we need it:
The commands used for testing jwt based routing miss host headers which cause 404.

Which issue(s) this PR fixes:
#3242

Fixes #3242 commands for testing jwt based routing

@biefy biefy requested a review from a team as a code owner April 22, 2024 08:46
@biefy biefy changed the title Fix commands for testing jwt based routing docs: Fix commands for testing jwt based routing Apr 22, 2024
zhaohuabing
zhaohuabing previously approved these changes Apr 22, 2024
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zirain
Copy link
Contributor

zirain commented Apr 22, 2024

/retest

zirain
zirain previously approved these changes Apr 22, 2024
@arkodg
Copy link
Contributor

arkodg commented Apr 22, 2024

thanks @biefy , can you also update site/content/en/latest/tasks/traffic/http-routing.md as well ?

@biefy biefy dismissed stale reviews from zirain and zhaohuabing via aabad1e April 23, 2024 02:45
@biefy
Copy link
Contributor Author

biefy commented Apr 23, 2024

Thanks @arkodg. Updated the latest http-routing.md.

biefy added 2 commits April 22, 2024 19:49
Fix commands for testing jwt based routing.

Signed-off-by: Fuyuan Bie <9142170+biefy@users.noreply.github.com>
Signed-off-by: Fuyuan Bie <9142170+biefy@users.noreply.github.com>
@zhaohuabing zhaohuabing merged commit 35c6891 into envoyproxy:main Apr 23, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: jwt based routing commands miss host header
4 participants