Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Write create files without the executable bit set #3255

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

liorokman
Copy link
Contributor

What this PR does / why we need it:
The file.Write function is used exclusively by unit tests to override testdata output. It is also a convenience to create the initial testdata output YAML files.

There's no reason to create YAML files with the executable bit set. This PR modifies the default mode used for file creation to not turn on the executable flag.

Signed-off-by: Lior Okman <lior.okman@sap.com>
@liorokman liorokman requested a review from a team as a code owner April 23, 2024 17:42
@arkodg arkodg merged commit 19032b0 into envoyproxy:main Apr 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants