fix: Add SourceMatchType validation for acceptable values #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Haynes <1472893+owenhaynes@users.noreply.github.com>
owenhaynes
force-pushed
the
add-validation-rule-source-match
branch
from
cd76551 to
683c18a
Compare
Signed-off-by: Owen Haynes <1472893+owenhaynes@users.noreply.github.com>
zirain
reviewed
Apr 24, 2024
Signed-off-by: Owen Haynes <1472893+owenhaynes@users.noreply.github.com>
|
you maye need to run |
|
I see no errors when running |
Signed-off-by: Owen Haynes <1472893+owenhaynes@users.noreply.github.com>
arkodg
approved these changes
Apr 24, 2024
shawnh2
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds validation to SourceMatch to only allow the accepted values. This is to prevent people using a lowercase version of "Distinct" which will then default to using "Exact" for the ratelimiting.
I lost a few hours to this 😄