Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor telemetry backendRefs #3293

Merged
merged 23 commits into from
May 22, 2024

remove status.RemoveGatewayListenersNotValidCondition

91e990f
Select commit
Loading
Failed to load commit list.
Merged

refactor telemetry backendRefs #3293

remove status.RemoveGatewayListenersNotValidCondition
91e990f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 22, 2024 in 0s

67.26% (target 60.00%)

View this Pull Request on Codecov

67.26% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 69.68085% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 67.26%. Comparing base (926d572) to head (91e990f).
Report is 14 commits behind head on main.

Files Patch % Lines
internal/provider/kubernetes/controller.go 4.54% 40 Missing and 2 partials ⚠️
internal/gatewayapi/route.go 79.41% 5 Missing and 2 partials ⚠️
internal/gatewayapi/listener.go 95.23% 2 Missing and 2 partials ⚠️
internal/gatewayapi/status/gateway.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3293      +/-   ##
==========================================
- Coverage   67.37%   67.26%   -0.12%     
==========================================
  Files         166      166              
  Lines       19357    19438      +81     
==========================================
+ Hits        13041    13074      +33     
- Misses       5376     5421      +45     
- Partials      940      943       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.