Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix helm IfNotPresent #3320

Merged
merged 2 commits into from
May 2, 2024
Merged

fix helm IfNotPresent #3320

merged 2 commits into from
May 2, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented May 2, 2024

  1. ImagePullPolicy be one of params of make helm-generate
  2. make sure set ImagePullPolicy=Always/IfNotPresent when run make helm-package and generate-manifests

cc @arkodg

@zirain
fix helm IfNotPresent
96bb4a4 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner May 2, 2024 10:41
@zirain
fix gen
32d1b19 
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
arkodg approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup !

@arkodg arkodg merged commit 1e4640a into envoyproxy:main May 2, 2024
23 checks passed
@zirain zirain deleted the helm-IfNotPresent branch May 2, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guydc guydc guydc approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirain @arkodg @guydc