feat(api): add consistent hash table size api #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
shawnh2
reviewed
May 8, 2024
api/v1alpha1/loadbalancer_types.go
Outdated
|
|
||
| // The table size for consistent hashing, must be prime number limited to 5000011. | ||
| // | ||
| // +kubebuilder:validation:Minimum=1 |
There was a problem hiding this comment.
should we make it 2? because 1 is actually not a prime number.
There was a problem hiding this comment.
Sure, make the minimum to the smallest prime number 2 now.
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
zirain
reviewed
May 8, 2024
| @@ -58,7 +58,7 @@ type ConsistentHash struct { | |||
|
|
|||
| // The table size for consistent hashing, must be prime number limited to 5000011. | |||
There was a problem hiding this comment.
can we add CEL to validate it must be prime number?
There was a problem hiding this comment.
Seems like CEL in Kubernetes 1 doesn't support complex validation logic like IsPrime function. But we can validate whether table size is prime number when translating ClientTrafficPolicy to IR.
func IsPrime(n int) bool {
if n <= 1 {
return false
}
for i := 2; i*i <= n; i++ {
if n%i == 0 {
return false
}
}
return true
}Footnotes
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
shawnh2
approved these changes
May 14, 2024
| @@ -58,7 +58,7 @@ type ConsistentHash struct { | |||
|
|
|||
| // The table size for consistent hashing, must be prime number limited to 5000011. | |||
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
May 15, 2024
* Add consistent hash table size api Signed-off-by: Dingkang Li <dingkang1743@gmail.com> * Set consistent hash table size's minimum as the smallest prime number: 2 Signed-off-by: Dingkang Li <dingkang1743@gmail.com> * Comment tableSize api as notImplementedHide Signed-off-by: Dingkang Li <dingkang1743@gmail.com> --------- Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add knob in BackendTrafficPolicy to configure consistent hash table size.
Which issue(s) this PR fixes:
Fixes #3272