Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix broken BackendTLSPolicy samples #3362

Merged
merged 1 commit into from
May 9, 2024
Merged

docs: fix broken BackendTLSPolicy samples #3362

merged 1 commit into from
May 9, 2024

Conversation

shahar-h
Copy link
Contributor

@shahar-h shahar-h commented May 9, 2024 •
edited
Loading

What this PR does / why we need it:
Fix BackendTLSPolicy samples in docs so they will be aligned with Gateway API v1.1.0.

Which issue(s) this PR fixes:

Fixes #

@shahar-h
docs: fix broken BackendTLSPolicy samples
a310bd2 
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner May 9, 2024 13:28
shawnh2
shawnh2 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

BTW, since the GRPCRoute also got updated to v1, can you send another PR to fix all the example around it in the doc? TIA!

@shahar-h
Copy link
Contributor Author

shahar-h commented May 9, 2024

/retest

1 similar comment
@shahar-h
Copy link
Contributor Author

shahar-h commented May 9, 2024

/retest

guydc
guydc approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@guydc guydc merged commit bb348dc into envoyproxy:main May 9, 2024
23 checks passed
@shahar-h shahar-h deleted the fix-btp-samples branch May 9, 2024 16:53
@shahar-h
Copy link
Contributor Author

shahar-h commented May 9, 2024

Thanks for fixing this!

BTW, since the GRPCRoute also got updated to v1, can you send another PR to fix all the example around it in the doc? TIA!

No API changes have been introduced in GRPCRoute besides addition of new sessionPersistence field under GRPCRouteRule, so no changes are required in docs.

@shawnh2
Copy link
Contributor

shawnh2 commented May 9, 2024

Thanks for fixing this!

BTW, since the GRPCRoute also got updated to v1, can you send another PR to fix all the example around it in the doc? TIA!

No API changes have been introduced in GRPCRoute besides addition of new sessionPersistence field under GRPCRouteRule, so no changes are required in docs.

Thanks for confirming this！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnh2 shawnh2 shawnh2 approved these changes

@guydc guydc guydc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahar-h @shawnh2 @guydc