-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add the buffer limit knob to the cluster #3390
Conversation
Signed-off-by: ShyunnY <1147212064@qq.com>
4b4a3d0
to
7ae2396
Compare
/retest |
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
Signed-off-by: ShyunnY <1147212064@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3390 +/- ##
==========================================
+ Coverage 67.11% 67.42% +0.30%
==========================================
Files 164 166 +2
Lines 23818 19184 -4634
==========================================
- Hits 15986 12935 -3051
+ Misses 6912 5320 -1592
- Partials 920 929 +9 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ShyunnY <1147212064@qq.com>
By the way, when The current gateway/api/v1alpha1/connection_types.go Lines 14 to 26 in 8206e11
Can we structure it like this? type struct BackendTrafficPolicyConnection {
...
}
type struct ClientTrafficPolicyConnection {
...
} |
prefer |
wow, this looks great, I vote! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
lets track the connection
refactor with a separate GH issue
/retest |
What type of PR is this?
api: add the buffer limit knob to the cluster
What this PR does / why we need it:
This PR aims to define the configuration structure of the
per_connection_buffer_limit_bytes
feature knobWhich issue(s) this PR fixes:
Related issues #3278