Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics instrumentation for xds server #3393

Merged
merged 2 commits into from
May 20, 2024
Merged

feat: add metrics instrumentation for xds server #3393

merged 2 commits into from
May 20, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented May 15, 2024 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

Fixes #2090

@shawnh2
add metrics instrumentation for xds server
e8366fb 
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner May 15, 2024 07:15
@shawnh2 shawnh2 requested review from zirain and Xunzhuo May 15, 2024 07:36
Xunzhuo
Xunzhuo reviewed May 15, 2024
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have more histogram metrics for measuring the xds duration.

@shawnh2
Copy link
Contributor Author

shawnh2 commented May 15, 2024 •
edited
Loading

I think we should have more histogram metrics for measuring the xds duration.

great! thanks, let me trying add more metrics for this

@shawnh2 shawnh2 marked this pull request as draft May 15, 2024 08:05
@shawnh2
add histogram metrics type for xds stream duration
f1dc4a4 
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 marked this pull request as ready for review May 15, 2024 09:49
@shawnh2 shawnh2 requested a review from Xunzhuo May 15, 2024 09:49
@ShyunnY
Copy link
Contributor

ShyunnY commented May 16, 2024

Are you considering adding additional namespace labels to metrics? This will facilitate our use of ns select in PromQL.

@shawnh2
Copy link
Contributor Author

shawnh2 commented May 16, 2024 •
edited
Loading

Are you considering adding additional namespace labels to metrics? This will facilitate our use of ns select in PromQL.

thanks for reporting, this will be investigated via #3361

@shawnh2 shawnh2 mentioned this pull request May 16, 2024
Closed
@shawnh2 shawnh2 requested review from a team May 17, 2024 04:51
arkodg
arkodg approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to be very useful, thanks for adding this !

@arkodg arkodg requested review from a team May 17, 2024 16:28
@shawnh2 shawnh2 mentioned this pull request May 20, 2024
Closed
zirain
zirain approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you can update the grafana dashboard.

@zirain zirain merged commit 8ca2675 into envoyproxy:main May 20, 2024
20 checks passed
@shawnh2 shawnh2 deleted the cp-metrics/xds-server branch May 20, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

@zirain zirain zirain approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Metrics instrumentation for xDS Server
5 participants
@shawnh2 @ShyunnY @zirain @arkodg @Xunzhuo