Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(zh): translate Install docs into Chinese #3403

Merged
merged 5 commits into from
May 17, 2024
Merged

docs(zh): translate Install docs into Chinese #3403

merged 5 commits into from
May 17, 2024

Conversation

wilsonwu
Copy link
Contributor

What type of PR is this?
translate Install docs into Chinese:

site/content/zh/latest/install/api.md
site/content/zh/latest/install/custom-cert.md
site/content/zh/latest/install/install-helm.md
site/content/zh/latest/install/install-yaml.md

@wilsonwu
translate Install docs into Chinese
b692d30 
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
@wilsonwu wilsonwu requested a review from a team as a code owner May 16, 2024 04:49
wilsonwu and others added 2 commits May 16, 2024 13:25
@wilsonwu @shawnh2
Apply suggestions from code review
2e40c80 
Co-authored-by: sh2 <shawnhxh@outlook.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
@wilsonwu
Fix the en link
886d4e9 
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
@wilsonwu
Apply suggestions
b10d39d 
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.05%. Comparing base (c4b0216) to head (886d4e9).
Report is 10 commits behind head on main.

❗ Current head 886d4e9 differs from pull request most recent head 269089b

Please upload reports for the commit 269089b to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3403      +/-   ##
==========================================
+ Coverage   66.97%   67.05%   +0.08%     
==========================================
  Files         164      166       +2     
  Lines       23882    23931      +49     
==========================================
+ Hits        15994    16047      +53     
+ Misses       6964     6960       -4     
  Partials      924      924

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yuluo-yx
yuluo-yx approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawnh2
Copy link
Contributor

shawnh2 commented May 17, 2024

/retest

shawnh2
shawnh2 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

zhaohuabing
zhaohuabing approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zhaohuabing zhaohuabing merged commit 02ff9eb into envoyproxy:main May 17, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuluo-yx yuluo-yx yuluo-yx approved these changes

@shawnh2 shawnh2 shawnh2 approved these changes

@zhaohuabing zhaohuabing zhaohuabing approved these changes

@zirain zirain Awaiting requested review from zirain

@qicz qicz Awaiting requested review from qicz

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wilsonwu @shawnh2 @zhaohuabing @zirain @yuluo-yx