API: Follow up on XFCC header #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3443 +/- ##
==========================================
- Coverage 67.35% 67.34% -0.01%
==========================================
Files 166 166
Lines 19357 19355 -2
==========================================
- Hits 13038 13035 -3
Misses 5378 5378
- Partials 941 942 +1 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
refactor-xfcc
branch
8 times, most recently
from
3edf9b0 to
18c35df
Compare
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
refactor-xfcc
branch
from
18c35df to
94bfa2f
Compare
shawnh2
approved these changes
May 21, 2024
cnvergence
approved these changes
May 21, 2024
arkodg
reviewed
May 21, 2024
arkodg
reviewed
May 21, 2024
| @@ -30,6 +30,7 @@ import ( | |||
| "google.golang.org/protobuf/types/known/wrapperspb" | |||
| "k8s.io/utils/ptr" | |||
|
|
|||
| egv1a1 "github.com/envoyproxy/gateway/api/v1alpha1" | |||
There was a problem hiding this comment.
we shouldnt be linking any Gateway API fields here, this lib should only be linked with the IR
There was a problem hiding this comment.
nvm this is internal to this project, but we should ideally avoid this too
arkodg
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a follow-up PR to address comments on #3202.
Close #2599