doc: add Envoy Gateway exported metrics #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
+ Coverage 67.35% 67.37% +0.02%
==========================================
Files 166 166
Lines 19357 19357
==========================================
+ Hits 13037 13041 +4
+ Misses 5379 5376 -3
+ Partials 941 940 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
cnvergence
reviewed
May 21, 2024
site/content/en/latest/tasks/observability/gateway-exported-metrics.md
Outdated
Show resolved
Hide resolved
cnvergence
approved these changes
May 21, 2024
…trics.md Co-authored-by: Karol Szwaj <karol.szwaj@gmail.com> Signed-off-by: sh2 <shawnhxh@outlook.com>
arkodg
reviewed
May 21, 2024
| @@ -0,0 +1,77 @@ | |||
| --- | |||
| title: "Gateway Exported Metrics" | |||
There was a problem hiding this comment.
can we call this Envoy Gateway Metrics or Control Plane Metrics ?
There was a problem hiding this comment.
How about Envoy Gateway Metrics List? The Envoy Gateway Metrics or Control Plane Metrics may be confusing, we need a name to tell whether this doc is for usage or for metrics list.
There was a problem hiding this comment.
sure that works too, merging this PR for now
arkodg
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3404