feat(translator): Implement tcp idle timeout in ClientTrafficPolicy #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
==========================================
+ Coverage 67.09% 67.11% +0.01%
==========================================
Files 166 166
Lines 19618 19633 +15
==========================================
+ Hits 13163 13176 +13
- Misses 5504 5505 +1
- Partials 951 952 +1 ☔ View full report in Codecov by Sentry. |
shawnh2
reviewed
May 24, 2024
| @@ -521,19 +525,34 @@ func translatePathSettings(pathSettings *egv1a1.PathSettings, httpIR *ir.HTTPLis | |||
| } | |||
| } | |||
|
|
|||
| func translateClientTimeout(clientTimeout *egv1a1.ClientTimeout, httpIR *ir.HTTPListener) error { | |||
| func buildClientTimeout(clientTimeout *egv1a1.ClientTimeout) (*ir.ClientTimeout, error) { | |||
There was a problem hiding this comment.
which func name prefix do we prefer here? I see we are using different prefix names for these func, like buildXXX and translateXXX?
Is a non blocking comment, but IMO we should unify them.
There was a problem hiding this comment.
vote for build, it's consistent with all the build methods in BTP
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
arkodg
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implement tcp idle timeout in ClientTrafficPolicy, follow up #3345
Which issue(s) this PR fixes:
Fixes #3343