ext_auth support backendRefs #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3469 +/- ##
==========================================
+ Coverage 67.22% 67.24% +0.02%
==========================================
Files 166 167 +1
Lines 19722 19744 +22
==========================================
+ Hits 13258 13277 +19
- Misses 5507 5512 +5
+ Partials 957 955 -2 ☔ View full report in Codecov by Sentry. |
3 tasks
zirain
changed the title
arkodg
reviewed
May 24, 2024
arkodg
reviewed
May 24, 2024
|
just realized, this is the Api PR :) |
everything is here.
is there any user case for this? |
zirain
force-pushed
the
api/ext-auth-backendref
branch
from
7e2f577 to
4329b2a
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
api/ext-auth-backendref
branch
from
1287a27 to
1aa1ef8
Compare
|
wait #3478 |
arkodg
approved these changes
May 28, 2024
shawnh2
approved these changes
May 29, 2024
|
|
||
| // BackendRefs references a Kubernetes object that represents the | ||
| // backend server to which the authorization request will be sent. | ||
| // Only service Kind is supported for now. |
There was a problem hiding this comment.
Suggested change
| // Only service Kind is supported for now. | |
| // Only Service kind is supported for now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #3091