Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use sets.Set[T] instead of map[T]struct{} #3471

Merged
merged 1 commit into from
May 24, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented May 24, 2024

fixes: #3411

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner May 24, 2024 09:29
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 70.49180% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 67.06%. Comparing base (c348370) to head (91a0897).

Files Patch % Lines
internal/provider/kubernetes/controller.go 40.90% 13 Missing ⚠️
internal/provider/kubernetes/routes.go 84.37% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3471      +/-   ##
==========================================
- Coverage   67.09%   67.06%   -0.03%     
==========================================
  Files         166      166              
  Lines       19618    19623       +5     
==========================================
- Hits        13163    13161       -2     
- Misses       5504     5509       +5     
- Partials      951      953       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain changed the title chore: use sets.Set instead of map[T]struct{} chore: use sets.Set[T] instead of map[T]struct{} May 24, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 8b71c60 into envoyproxy:main May 24, 2024
23 checks passed
@zirain zirain deleted the use-sets branch May 24, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use sets in the kube provider to keep track of existing resources
3 participants