benchmark: add support for memory profiling #3701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
shawnh2
commented
Jun 29, 2024
| @@ -164,6 +165,12 @@ run-benchmark: install-benchmark-server ## Run benchmark tests | |||
| kubectl wait --timeout=$(WAIT_TIMEOUT) -n envoy-gateway-system deployment/envoy-gateway --for=condition=Available | |||
| kubectl apply -f test/benchmark/config/gatewayclass.yaml | |||
| go test -v -tags benchmark -timeout $(BENCHMARK_TIMEOUT) ./test/benchmark --rps=$(BENCHMARK_RPS) --connections=$(BENCHMARK_CONNECTIONS) --duration=$(BENCHMARK_DURATION) --report-save-path=benchmark_report.md | |||
| # render benchmark profiles into image | |||
| dot -V | |||
There was a problem hiding this comment.
blocked by #3692, need to deploy graphviz in github action
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
+ Coverage 68.55% 68.85% +0.30%
==========================================
Files 170 175 +5
Lines 20690 21525 +835
==========================================
+ Hits 14183 14821 +638
- Misses 5492 5628 +136
- Partials 1015 1076 +61 ☔ View full report in Codecov by Sentry. |
shawnh2
commented
Jun 30, 2024
| @@ -234,7 +237,18 @@ func renderMetricsTable(writer io.Writer, headerSettings []ReportTableHeader, re | |||
| return nil | |||
| } | |||
|
|
|||
| func renderMetricsTableHeader(table *tabwriter.Writer, headers []ReportTableHeader) { | |||
| func renderProfilesTable(writer io.Writer, target, key string, titleLevel int, reports []*BenchmarkReport) { | |||
There was a problem hiding this comment.
blocked by #3709, need to update the doc later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
To help understanding memory, add memory profiles to benchmark report.
Which issue(s) this PR fixes:
xref: #3698