Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support session persistence in HTTPRouteRule #3841

Merged
merged 20 commits into from
Aug 10, 2024

Merge branch 'main' into session-persistence

c5947c5
Select commit
Loading
Failed to load commit list.
Merged

feat: support session persistence in HTTPRouteRule #3841

Merge branch 'main' into session-persistence
c5947c5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 8, 2024 in 0s

67.58% (target 60.00%)

View this Pull Request on Codecov

67.58% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 58.40708% with 47 lines in your changes missing coverage. Please review.

Project coverage is 67.58%. Comparing base (975b1e8) to head (c5947c5).

Files Patch % Lines
internal/gatewayapi/route.go 12.50% 27 Missing and 1 partial ⚠️
internal/xds/translator/session_persistence.go 75.64% 10 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3841      +/-   ##
==========================================
- Coverage   67.61%   67.58%   -0.03%     
==========================================
  Files         185      186       +1     
  Lines       22578    22689     +111     
==========================================
+ Hits        15265    15335      +70     
- Misses       6217     6251      +34     
- Partials     1096     1103       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.