feat: finalize envoyproxy for gatewayclass #3930
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3930 +/- ##
==========================================
- Coverage 67.92% 67.92% -0.01%
==========================================
Files 187 187
Lines 23018 23057 +39
==========================================
+ Hits 15636 15661 +25
- Misses 6266 6273 +7
- Partials 1116 1123 +7 ☔ View full report in Codecov by Sentry. |
cnvergence
force-pushed
the
feat-finalize-ep
branch
2 times, most recently
from
6f98cce to
47bda41
Compare
cnvergence
force-pushed
the
feat-finalize-ep
branch
from
941f7c0 to
25ea8b2
Compare
cnvergence
added
the
provider/kubernetes
|
HI @cnvergence thanks for picking this up. This PR overall looks good; I just have a few comments. |
|
/retest |
cnvergence
force-pushed
the
feat-finalize-ep
branch
from
869e7fd to
bab6210
Compare
|
/retest |
cnvergence
force-pushed
the
feat-finalize-ep
branch
from
def83d3 to
90aa23b
Compare
cnvergence
force-pushed
the
feat-finalize-ep
branch
from
ec6d16b to
0e40fc3
Compare
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Co-authored-by: sh2 <shawnhxh@outlook.com> Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
feat-finalize-ep
branch
from
4d71857 to
e5a0f40
Compare
…ultiple gc Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
feat-finalize-ep
branch
from
e5a0f40 to
f5c974b
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
|
/retest |
|
@shawnh2 @zhaohuabing had you chance to take a look again? |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
What type of PR is this?
What this PR does / why we need it:
Restore work on EnvoyProxy finalizers, only for those referenced by the GatewayClass.
We have ran into issues with Merged Gateways deployments. #3533 (comment)
Which issue(s) this PR fixes:
Fixes #865