-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: find a way to reenable the cherry-picker process #3958
Conversation
Signed-off-by: Manoramsharma <img_2020037@iiitm.ac.in>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3958 +/- ##
==========================================
+ Coverage 67.36% 67.45% +0.09%
==========================================
Files 183 183
Lines 22443 22443
==========================================
+ Hits 15118 15140 +22
+ Misses 6233 6217 -16
+ Partials 1092 1086 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directly push to target branch is not allowed
Signed-off-by: Manoramsharma <img_2020037@iiitm.ac.in>
types: ["closed"] | ||
|
||
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we create branch with read permission?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing that out. I should have update the permissions in the workflow to ensure that the action can create and push branches. The permissions should be set to contents: write
and pull-requests: write
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Manoramsharma thanks for you work, but I think this's not a good issue for begginer(this one need a lot of collaborations with the Envoyproxy org admin).
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
As we discussed, we won't need this for now. |
What type of PR is this?
CI workflow
What this PR does / why we need it:
This PR introduces a custom GitHub Actions workflow to automate the cherry-picking of merged pull requests with a specific label into a target branch. This automation simplifies the release management process and ensures that critical changes are propagated to the necessary branches efficiently.
Which issue(s) this PR fixes:
Fixes #3946
Changes made in this PR:
cherry-picker.yml
) to automate the cherry-picking process.main
branch is closed.cherrypick/release-v1.1
and if it was merged.release/v1.1
.Additional context:
This workflow helps in reducing manual effort for the release manager by automating the process of cherry-picking merged PRs with specific labels into their respective release branches.