Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix egctl experimental translate with error ns. #3984

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

qicz
Copy link
Member

@qicz qicz commented Aug 1, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3982

Signed-off-by: qicz <qiczzhu@gmail.com>
@qicz qicz requested a review from a team as a code owner August 1, 2024 09:59
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.55%. Comparing base (eac30d6) to head (f0615a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3984      +/-   ##
==========================================
- Coverage   67.59%   67.55%   -0.05%     
==========================================
  Files         186      186              
  Lines       22767    22769       +2     
==========================================
- Hits        15390    15381       -9     
- Misses       6272     6278       +6     
- Partials     1105     1110       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qicz and others added 2 commits August 2, 2024 10:06
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: qi <z@openingo.org>
@qicz qicz requested a review from arkodg August 6, 2024 05:27
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team August 6, 2024 22:13
@guydc
Copy link
Contributor

guydc commented Aug 12, 2024

/retest

@arkodg arkodg merged commit eb83fb7 into envoyproxy:main Aug 13, 2024
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

egctl experimental translate using bad ns
4 participants