Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean envoygateway validate methods #3997

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 4, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Prepare for #3159, this part is very likely to get conflicts.

shawnh2 added 2 commits August 4, 2024 21:45
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner August 4, 2024 13:57
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 88.76404% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (c2c705b) to head (7203618).

Files Patch % Lines
api/v1alpha1/validation/envoygateway_validate.go 88.76% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3997      +/-   ##
==========================================
+ Coverage   67.59%   67.67%   +0.07%     
==========================================
  Files         183      183              
  Lines       22446    22471      +25     
==========================================
+ Hits        15173    15207      +34     
+ Misses       6193     6185       -8     
+ Partials     1080     1079       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Aug 5, 2024

/retest

@shawnh2 shawnh2 merged commit afbc5e2 into envoyproxy:main Aug 5, 2024
24 checks passed
@shawnh2 shawnh2 deleted the refactor-envoygateway-validate branch August 5, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants