feat(translator): early request header modifier #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4004 +/- ##
=========================================
+ Coverage 0 67.90% +67.90%
=========================================
Files 0 187 +187
Lines 0 23022 +23022
=========================================
+ Hits 0 15633 +15633
- Misses 0 6276 +6276
- Partials 0 1113 +1113 ☔ View full report in Codecov by Sentry. |
|
/retest |
liorokman
approved these changes
Aug 10, 2024
| continue | ||
| } | ||
| // Per Gateway API specification on HTTPHeaderName, : and / are invalid characters in header names | ||
| if strings.Contains(string(addHeader.Name), "/") || strings.Contains(string(addHeader.Name), ":") { |
There was a problem hiding this comment.
Maybe use strings.ContainsAny instead?
| continue | ||
| } | ||
| // Per Gateway API specification on HTTPHeaderName, : and / are invalid characters in header names | ||
| if strings.Contains(string(setHeader.Name), "/") || strings.Contains(string(setHeader.Name), ":") { |
There was a problem hiding this comment.
ContainsAny instead of multiple Contains here as well.
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
reviewed
Aug 13, 2024
| // routing, tracing and built-in header manipulation. | ||
| // | ||
| // +optional | ||
| EarlyRequestHeaderModifier *gwapiv1.HTTPHeaderFilter `json:"earlyRequestHeaderModifier,omitempty"` |
There was a problem hiding this comment.
thoughts on earlyRequestHeaders ?
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
Signed-off-by: Guy Daich <guy.daich@sap.com>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds support for early request header mutation in client traffic policy
Which issue(s) this PR fixes:
Fixes #3978