Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade test should use v1.1.0 by default #4005

Closed
wants to merge 1 commit into from

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Aug 5, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Guy Daich <guy.daich@sap.com>
@guydc guydc requested a review from a team as a code owner August 5, 2024 21:05
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.60%. Comparing base (0f75173) to head (56e2d90).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4005      +/-   ##
==========================================
+ Coverage   67.58%   67.60%   +0.01%     
==========================================
  Files         184      184              
  Lines       22521    22521              
==========================================
+ Hits        15221    15225       +4     
+ Misses       6215     6213       -2     
+ Partials     1085     1083       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested review from a team August 5, 2024 22:08
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shawnh2
Copy link
Contributor

shawnh2 commented Aug 5, 2024

/retest

@guydc
Copy link
Contributor Author

guydc commented Aug 6, 2024

looks like we have a legitimate v1.1 => main upgrade issue

@guydc guydc closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants