Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the wasm download URL to point to the envoy examples repository #4014

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

liorokman
Copy link
Contributor

@liorokman liorokman commented Aug 8, 2024

What this PR does / why we need it:
Envoy moved all their examples from the envoy repository to a new examples repository. The URL to the wasm example must be updated in the E2E tests.

envoyproxy/envoy@56be4f4

Signed-off-by: Lior Okman <lior.okman@sap.com>
@liorokman liorokman requested a review from a team as a code owner August 8, 2024 10:02
@liorokman
Copy link
Contributor Author

@guydc @zhaohuabing I hope this will fix the E2E tests...

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.61%. Comparing base (866a6ce) to head (b30d882).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4014      +/-   ##
==========================================
- Coverage   67.64%   67.61%   -0.03%     
==========================================
  Files         185      185              
  Lines       22578    22578              
==========================================
- Hits        15272    15267       -5     
- Misses       6213     6216       +3     
- Partials     1093     1095       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liorokman
Copy link
Contributor Author

/retest

1 similar comment
@liorokman
Copy link
Contributor Author

/retest

@zirain
Copy link
Member

zirain commented Aug 8, 2024

@liorokman
Copy link
Contributor Author

can we move https://github.com/envoyproxy/gateway/tree/main/examples/extension-server to that repo?

I don't know. Good question. Does the Gateway project have any body to ask from the main Envoy project about this?

@zirain
Copy link
Member

zirain commented Aug 8, 2024

can we move https://github.com/envoyproxy/gateway/tree/main/examples/extension-server to that repo?

I don't know. Good question. Does the Gateway project have any body to ask from the main Envoy project about this?

I think we can try.

Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@guydc guydc merged commit 975b1e8 into envoyproxy:main Aug 8, 2024
24 checks passed
@liorokman liorokman deleted the fix-wasm-download-url branch August 8, 2024 12:30
arkodg pushed a commit to arkodg/gateway that referenced this pull request Sep 3, 2024
…sitory (envoyproxy#4014)

Fix the wasm download URL to point to the envoy examples repository.

Signed-off-by: Lior Okman <lior.okman@sap.com>
(cherry picked from commit 975b1e8)
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain pushed a commit that referenced this pull request Sep 3, 2024
…y examples repo… (#4151)

fix: change the wasm download URL to point to the envoy examples repository (#4014)

Fix the wasm download URL to point to the envoy examples repository.


(cherry picked from commit 975b1e8)

Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Co-authored-by: Lior Okman <lior.okman@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants