-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change the wasm download URL to point to the envoy examples repository #4014
Conversation
Signed-off-by: Lior Okman <lior.okman@sap.com>
@guydc @zhaohuabing I hope this will fix the E2E tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4014 +/- ##
==========================================
- Coverage 67.64% 67.61% -0.03%
==========================================
Files 185 185
Lines 22578 22578
==========================================
- Hits 15272 15267 -5
- Misses 6213 6216 +3
- Partials 1093 1095 +2 ☔ View full report in Codecov by Sentry. |
/retest |
1 similar comment
/retest |
can we move https://github.com/envoyproxy/gateway/tree/main/examples/extension-server to that repo? |
I don't know. Good question. Does the |
I think we can try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…sitory (envoyproxy#4014) Fix the wasm download URL to point to the envoy examples repository. Signed-off-by: Lior Okman <lior.okman@sap.com> (cherry picked from commit 975b1e8) Signed-off-by: Arko Dasgupta <arko@tetrate.io>
…y examples repo… (#4151) fix: change the wasm download URL to point to the envoy examples repository (#4014) Fix the wasm download URL to point to the envoy examples repository. (cherry picked from commit 975b1e8) Signed-off-by: Lior Okman <lior.okman@sap.com> Signed-off-by: Arko Dasgupta <arko@tetrate.io> Co-authored-by: Lior Okman <lior.okman@sap.com>
What this PR does / why we need it:
Envoy moved all their examples from the
envoy
repository to a newexamples
repository. The URL to the wasm example must be updated in the E2E tests.envoyproxy/envoy@56be4f4