docs: Attach EnvoyProxy to Gateway #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: envoyproxy#3639 Signed-off-by: Arko Dasgupta <arko@tetrate.io> (cherry picked from commit a3c259a) Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4020 +/- ##
==========================================
- Coverage 67.61% 67.59% -0.02%
==========================================
Files 186 186
Lines 22757 22757
==========================================
- Hits 15387 15383 -4
- Misses 6266 6268 +2
- Partials 1104 1106 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
zirain
reviewed
Aug 9, 2024
There was a problem hiding this comment.
I recall there's a PR from @shawnh2 handle this?
There was a problem hiding this comment.
looks like it was only added to latest
zirain
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3639